Attention is currently required from: Andrey Pronin, Raul Rangel, Christian Walter, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59479 )
Change subject: drivers/tpm: Add firmware-power-managed DSD property
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/i2c/tpm/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133832):
https://review.coreboot.org/c/coreboot/+/59479/comment/d11a44f0_a8c92de5
PS5, Line 53: switch(config->power_managed_mode) {
space required before the open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b
Gerrit-Change-Number: 59479
Gerrit-PatchSet: 5
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 19:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment