Attention is currently required from: Michał Żygowski, Piotr Król.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56836 )
Change subject: mb/pcengines/apu2: add and use IOMUX defines
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/pcengines/apu2/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125811):
https://review.coreboot.org/c/coreboot/+/56836/comment/852a2b42_c978fa68
PS1, Line 47: PAD_GPI(GPIO_32,PULL_NONE),
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie32df9ed2cb6a5670a29cff91e085a3585c8bcf7
Gerrit-Change-Number: 56836
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 05 Aug 2021 19:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment