EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 6 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 4348ef5..1d29f90 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -3,6 +3,7 @@ select BOARD_ROMSIZE_KB_32768 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_ALDERLAKE
if BOARD_GOOGLE_BASEBOARD_BRYA @@ -11,6 +12,11 @@ def_bool n select SYSTEM_TYPE_LAPTOP
+config CHROMEOS + bool + default y + select VBOOT_LID_SWITCH + config DEVICETREE string default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc index cdd0eb6..3735e20 100644 --- a/src/mainboard/google/brya/Makefile.inc +++ b/src/mainboard/google/brya/Makefile.inc @@ -1,7 +1,12 @@ bootblock-y += bootblock.c +bootblock-$(CONFIG_CHROMEOS) += chromeos.c
+verstage-$(CONFIG_CHROMEOS) += chromeos.c + +romstage-$(CONFIG_CHROMEOS) += chromeos.c romstage-y += romstage.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += mainboard.c
VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR)) diff --git a/src/mainboard/google/brya/chromeos.c b/src/mainboard/google/brya/chromeos.c new file mode 100644 index 0000000..e222ca2 --- /dev/null +++ b/src/mainboard/google/brya/chromeos.c @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boot/coreboot_tables.h> +#include <gpio.h> +#include <vendorcode/google/chromeos/chromeos.h> + +void fill_lb_gpios(struct lb_gpios *gpios) +{ + struct lb_gpio chromeos_gpios[] = { + {-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"}, + {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, + {-1, ACTIVE_HIGH, 0, "power"}, + {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, + }; + lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); +} + +int get_lid_switch(void) +{ + /* TODO: use Chrome EC switches when EC support is added */ + return 1; +} + +int get_recovery_mode_switch(void) +{ + /* TODO: use Chrome EC switches when EC support is added */ + return 0; +} + +int get_write_protect_state(void) +{ + /* No write protect */ + return 0; +} + +void mainboard_chromeos_acpi_generate(void) +{ + const struct cros_gpio *gpios; + size_t num; + gpios = variant_cros_gpios(&num); + chromeos_acpi_gpio_generate(gpios, num); +} + diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index f15f25e..5930430 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -26,4 +26,7 @@ } /* Chipset specific sleep states */ #include <southbridge/intel/common/acpi/sleepstates.asl> + + /* Chrome OS specific */ + #include <vendorcode/google/chromeos/acpi/chromeos.asl> } diff --git a/src/mainboard/google/brya/variants/baseboard/gpio.c b/src/mainboard/google/brya/variants/baseboard/gpio.c index 0f5b298..8179e2f 100644 --- a/src/mainboard/google/brya/variants/baseboard/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/gpio.c @@ -3,6 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> +#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage*/ static const struct pad_config gpio_table[] = { @@ -25,3 +26,12 @@ *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table; } + +static const struct cros_gpio cros_gpios[] = { +}; + +const struct cros_gpio *__weak variant_cros_gpios(size_t *num) +{ + *num = ARRAY_SIZE(cros_gpios); + return cros_gpios; +} diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index 8531f7d..6e31712 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -10,5 +10,6 @@ * entries for each table. */ const struct pad_config *variant_gpio_table(size_t *num); const struct pad_config *variant_early_gpio_table(size_t *num); +const struct cros_gpio *variant_cros_gpios(size_t *num);
#endif /*__BASEBOARD_VARIANTS_H__ */
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48111
to look at the new patch set (#2).
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 6 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... File src/mainboard/google/brya/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... PS3, Line 2: bootblock-$(CONFIG_CHROMEOS) += chromeos.c not used in bootblock
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... PS3, Line 12: {-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"}, not necessary anymore, see CB:39318
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... File src/mainboard/google/brya/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... PS3, Line 2: bootblock-$(CONFIG_CHROMEOS) += chromeos.c
not used in bootblock
This confused me as well. Agree!
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... PS3, Line 12: {-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"},
not necessary anymore, see CB:39318
Yes, I forgot this.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48111
to look at the new patch set (#4).
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 7 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48111
to look at the new patch set (#5).
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 7 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 5:
@Tim, you forgot this one :p
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 5:
Patch Set 5:
@Tim, you forgot this one :p
https://review.coreboot.org/c/coreboot/+/48069/5/src/mainboard/google/brya/m...
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 5:
yes, on the way.. just wait few minutes.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48111
to look at the new patch set (#6).
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 7 files changed, 70 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/6
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48111
to look at the new patch set (#7).
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 7 files changed, 70 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/48111/7
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c... File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c... PS7, Line 15: }; note to us: once the GPIO table is straightened out, we need EC_IN_RW here too
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c... File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/7/src/mainboard/google/brya/c... PS7, Line 15: };
note to us: once the GPIO table is straightened out, we need EC_IN_RW here too
Got it:)
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
mb/google/brya: Enable building for Chrome OS
Enable building for Chrome OS and add associated ACPI configuration.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48111 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/chromeos.c M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 7 files changed, 70 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 4a9f2e1..f955b64 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -4,6 +4,7 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE + select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_ALDERLAKE
if BOARD_GOOGLE_BASEBOARD_BRYA @@ -12,6 +13,11 @@ def_bool n select SYSTEM_TYPE_LAPTOP
+config CHROMEOS + bool + default y + select VBOOT_LID_SWITCH + config DEVICETREE string default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc index cdd0eb6..fda1bfb 100644 --- a/src/mainboard/google/brya/Makefile.inc +++ b/src/mainboard/google/brya/Makefile.inc @@ -1,7 +1,11 @@ bootblock-y += bootblock.c
+verstage-$(CONFIG_CHROMEOS) += chromeos.c + +romstage-$(CONFIG_CHROMEOS) += chromeos.c romstage-y += romstage.c
+ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += mainboard.c
VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR)) diff --git a/src/mainboard/google/brya/chromeos.c b/src/mainboard/google/brya/chromeos.c new file mode 100644 index 0000000..2e6ea3e --- /dev/null +++ b/src/mainboard/google/brya/chromeos.c @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boot/coreboot_tables.h> +#include <gpio.h> +#include <vendorcode/google/chromeos/chromeos.h> + +void fill_lb_gpios(struct lb_gpios *gpios) +{ + struct lb_gpio chromeos_gpios[] = { + {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, + {-1, ACTIVE_HIGH, 0, "power"}, + {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, + }; + lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); +} + +int get_lid_switch(void) +{ + /* TODO: use Chrome EC switches when EC support is added */ + return 1; +} + +int get_recovery_mode_switch(void) +{ + /* TODO: use Chrome EC switches when EC support is added */ + return 0; +} + +int get_write_protect_state(void) +{ + /* No write protect */ + return 0; +} + +void mainboard_chromeos_acpi_generate(void) +{ + const struct cros_gpio *gpios; + size_t num; + gpios = variant_cros_gpios(&num); + chromeos_acpi_gpio_generate(gpios, num); +} diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index ebb6ec5..4fc205a 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -30,4 +30,7 @@
/* Chipset specific sleep states */ #include <southbridge/intel/common/acpi/sleepstates.asl> + + /* Chrome OS specific */ + #include <vendorcode/google/chromeos/acpi/chromeos.asl> } diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c index d7c3156..fd0d5b6 100644 --- a/src/mainboard/google/brya/mainboard.c +++ b/src/mainboard/google/brya/mainboard.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
+#include <acpi/acpi.h> #include <baseboard/variants.h> #include <device/device.h> +#include <vendorcode/google/chromeos/chromeos.h>
static void mainboard_init(void *chip_info) { @@ -13,7 +15,7 @@
static void mainboard_enable(struct device *dev) { - /* TODO: Enable mainboard */ + dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/google/brya/variants/baseboard/gpio.c b/src/mainboard/google/brya/variants/baseboard/gpio.c index 39450ce..12e725f 100644 --- a/src/mainboard/google/brya/variants/baseboard/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/gpio.c @@ -3,6 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> +#include <vendorcode/google/chromeos/chromeos.h>
/* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { @@ -25,3 +26,12 @@ *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table; } + +static const struct cros_gpio cros_gpios[] = { +}; + +const struct cros_gpio *__weak variant_cros_gpios(size_t *num) +{ + *num = ARRAY_SIZE(cros_gpios); + return cros_gpios; +} diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index 95f2d65..663306c 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -12,5 +12,6 @@
const struct pad_config *variant_gpio_table(size_t *num); const struct pad_config *variant_early_gpio_table(size_t *num); +const struct cros_gpio *variant_cros_gpios(size_t *num);
#endif /*__BASEBOARD_VARIANTS_H__ */
Attention is currently required from: Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/4bce125f_1e3481fe PS9, Line 18: default y This prevents build-testing the !CHROMEOS case.
Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/fee7b607_ca470ba6 PS9, Line 18: default y
This prevents build-testing the !CHROMEOS case.
What do you want to do with this? All chrome project set default y
Attention is currently required from: Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/0a065838_886ee2b4 PS9, Line 18: default y
What do you want to do with this? All chrome project set default y
Just remove the default. abuild has an option to build with CHROMEOS enabled, and Jenkins uses it to build-test both the default (assumed to be !CHROMEOS) and CHROMEOS cases. This default makes Jenkins build-test with CHROMEOS twice.
Related changes: CB:49059 CB:49101 CB:49102 CB:49103
Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/914e5773_440f0ca6 PS9, Line 18: default y
Just remove the default. […]
Do you want to clean up for all chrome projects? Or just brya?
Attention is currently required from: Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/b42211bb_7a9c3e8a PS9, Line 18: default y
Do you want to clean up for all chrome projects? Or just brya?
All of them. Not everyone runs ChromeOS on chrome devices 😊
Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/243f99e0_ebc392ac PS9, Line 18: default y
All of them. […]
I can submit it, but not sure how the chrome build system working. This will sync to Chrome ToT and build with google server...
Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/92542825_b177ee71 PS9, Line 18: default y
I can submit it, but not sure how the chrome build system working. […]
But this is under the if statement, this only effect brya only, right? Our device only run with ChromeOS. We don't want another purpose for this device. @Tim, what do you think? "if BOARD_GOOGLE_BASEBOARD_BRYA"
Attention is currently required from: Tim Wawrzynczak, EricR Lai. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/e6004ed2_75c6fb33 PS9, Line 18: default y
But this is under the if statement, this only effect brya only, right? Our device only run with Chro […]
Let's see what CB:50118 comes up with.
We probably want the case CHROMEOS=n always build-tested, regardless of the products shipping with CHROMEOS=y.
Attention is currently required from: EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/dcd17031_9c85786b PS9, Line 18: default y
Let's see what CB:50118 comes up with. […]
Thanks for the pointer Angel!
As an example, after the products are released, MrChromebox oftentimes adds support for other OSes/payloads, etc. so it is perfectly valid to expect it to build with or without CHROMEOS defined here.
Eric, we can certainly add the CONFIG_CHROMEOS to our e.g., config.bry0a files, that's no problem, we just need to coordinate between our config & upstream coreboot so we don't end up with broken builds over on our side.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/40a0e8c5_c6a98a79 PS9, Line 18: default y
Thanks for the pointer Angel! […]
oh, yes. We can add config in our overlay tree. I think CL need to take care when Upstream.
-
Angel Pons (Code Review) -
EricR Lai (Code Review)
-
Kyösti Mälkki (Code Review)
-
Tim Wawrzynczak (Code Review)