Change in coreboot[master]: mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36316 )
Change subject: mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()' ......................................................................
mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()'
Processor() operator is deprecated, use Device() instead.
Change-Id: I1650df927aa6d4a1282ed50b2bcbb63d5bd04347 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl 1 file changed, 16 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36316/1
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl index 0c4cd38..29b146b 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl +++ b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl @@ -18,10 +18,22 @@
// Scope (_PR) // { -// Processor (CPU0, 0x00, 0x0000C010, 0x06) {} -// Processor (CPU1, 0x01, 0x00000000, 0x00) {} -// Processor (CPU2, 0x02, 0x00000000, 0x00) {} -// Processor (CPU3, 0x03, 0x00000000, 0x00) {} +// Device (CPU0) { +// Name (_HID, "ACPI0007") +// Name (_UID, 0) +// } +// Device (CPU1) { +// Name (_HID, "ACPI0007") +// Name (_UID, 1) +// } +// Device (CPU2) { +// Name (_HID, "ACPI0007") +// Name (_UID, 2) +// } +// Device (CPU3) { +// Name (_HID, "ACPI0007") +// Name (_UID, 3) +// } // }
Method (FWSO, 0, NotSerialized) { }
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36316 )
Change subject: mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()' ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36316 )
Change subject: mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()' ......................................................................
mb/amd/serengeti_cheetah_fam10: Use 'Device()' instead of 'Processor()'
Processor() operator is deprecated, use Device() instead.
Change-Id: I1650df927aa6d4a1282ed50b2bcbb63d5bd04347 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36316 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl 1 file changed, 16 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl index 0c4cd38..29b146b 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl +++ b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl @@ -18,10 +18,22 @@
// Scope (_PR) // { -// Processor (CPU0, 0x00, 0x0000C010, 0x06) {} -// Processor (CPU1, 0x01, 0x00000000, 0x00) {} -// Processor (CPU2, 0x02, 0x00000000, 0x00) {} -// Processor (CPU3, 0x03, 0x00000000, 0x00) {} +// Device (CPU0) { +// Name (_HID, "ACPI0007") +// Name (_UID, 0) +// } +// Device (CPU1) { +// Name (_HID, "ACPI0007") +// Name (_UID, 1) +// } +// Device (CPU2) { +// Name (_HID, "ACPI0007") +// Name (_UID, 2) +// } +// Device (CPU3) { +// Name (_HID, "ACPI0007") +// Name (_UID, 3) +// } // }
Method (FWSO, 0, NotSerialized) { }
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)