Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver ......................................................................
Patch Set 12:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84929/comment/f48f9b9f_d72bd783?usp... : PS12, Line 10: hen bus move to previous line
https://review.coreboot.org/c/coreboot/+/84929/comment/813c4ee7_ffb50772?usp... : PS12, Line 13: hw HW or hwardware
https://review.coreboot.org/c/coreboot/+/84929/comment/c5a476b7_56115df2?usp... : PS12, Line 13: build Build
https://review.coreboot.org/c/coreboot/+/84929/comment/33843053_79a68a70?usp... : PS12, Line 14: causes the platform to restart triggers a reset to the platform,
https://review.coreboot.org/c/coreboot/+/84929/comment/3891cc71_4f1ac844?usp... : PS12, Line 19: has a bus timeout. move to previous line.
File src/soc/mediatek/mt8196/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/668331ba_93b398a9?usp... : PS12, Line 8: tracker_common tracker.h
File src/soc/mediatek/mt8196/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/84929/comment/dc777770_fe69439b?usp... : PS12, Line 49: 78K) The change is probably no longer needed.
File src/soc/mediatek/mt8196/include/soc/tracker.h:
https://review.coreboot.org/c/coreboot/+/84929/comment/0fed6093_a6edb771?usp... : PS12, Line 5: #include <soc/tracker_common.h>
File src/soc/mediatek/mt8196/tracker.c:
https://review.coreboot.org/c/coreboot/+/84929/comment/c89a143d_961c0e44?usp... : PS12, Line 8: #include <soc/tracker_common.h> remove
https://review.coreboot.org/c/coreboot/+/84929/comment/786993ee_03d51afc?usp... : PS12, Line 71: ( parentheses is not needed.