Attention is currently required from: Angel Pons, Felix Singer, Maximilian Brune, Name of user not set #1005283.
Alicja Michalska has posted comments on this change by Name of user not set #1005283. ( https://review.coreboot.org/c/coreboot/+/79979?usp=email )
Change subject: mainboard: Add MSI MS-7788 ......................................................................
Patch Set 9:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79979/comment/6dc61c93_aa7ddad1?usp... : PS9, Line 11: * I disabled it and everything seems to work... Add early init to your mainboard tree, disable it in bootblock by calling the function:
``` #include <bootblock_common.h> #include <northbridge/intel/sandybridge/sandybridge.h>
void bootblock_mainboard_early_init(void) { mchbar_write16(SSKPD_HI, 0); } ```
https://review.coreboot.org/c/coreboot/+/79979/comment/9ecd826e_d3ed9683?usp... : PS9, Line 44: * PS/2 Likely won't work without configuring SIO registers
https://review.coreboot.org/c/coreboot/+/79979/comment/ff450a84_2c4e1baa?usp... : PS9, Line 47: Signed-off-by: mrhh69 122405954+mrhh69@users.noreply.github.com Incorrect sign-off
File src/mainboard/msi/ms7788/Kconfig:
https://review.coreboot.org/c/coreboot/+/79979/comment/6506076a_c335c1fa?usp... : PS9, Line 1: if BOARD_MSI_MS_7788 Missing license identifier
File src/mainboard/msi/ms7788/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/79979/comment/4273552d_d345191c?usp... : PS9, Line 1: config BOARD_MSI_MS_7788 Missing license identifier
File src/mainboard/msi/ms7788/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79979/comment/f0a02bea_e37d5e09?usp... : PS9, Line 8: register "docking_supported" = "0" Why? This board isn't a laptop, right?
File src/northbridge/intel/sandybridge/romstage.c:
https://review.coreboot.org/c/coreboot/+/79979/comment/652e8c1b_ad3f409d?usp... : PS9, Line 56: //if (mchbar_read16(SSKPD_HI) == 0xcafe) Please avoid modifying common code. If there are other mainboards experiencing the same issue, we could convert it to Kconfig option.