Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61552 )
Change subject: soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b() ......................................................................
soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b()
Move lpc_enable_fixed_io_ranges into the if statement so that it doesn't override what lpc_io_setup_comm_a_b() has done.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I3c28e8dcc1813740b2862b340c95bb80dab9d91e --- M src/soc/intel/tigerlake/bootblock/pch.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/61552/1
diff --git a/src/soc/intel/tigerlake/bootblock/pch.c b/src/soc/intel/tigerlake/bootblock/pch.c index 7351492..7fcb103 100644 --- a/src/soc/intel/tigerlake/bootblock/pch.c +++ b/src/soc/intel/tigerlake/bootblock/pch.c @@ -119,15 +119,14 @@
if (config->lpc_ioe) { io_enables = config->lpc_ioe & lpc_ioe_enable_mask; + /* IO Decode Enable */ + lpc_enable_fixed_io_ranges(io_enables); } else { /* IO Decode Range */ if (CONFIG(DRIVERS_UART_8250IO)) lpc_io_setup_comm_a_b(); }
- /* IO Decode Enable */ - lpc_enable_fixed_io_ranges(io_enables); - /* Program generic IO Decode Range */ pch_enable_lpc(); }