[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver - coreboot-gerrit

21 Apr 2024


      Attention is currently required from: Dolan Liu, Elyes Haouas, Eric Lai, Jianeng Ceng, Matt DeVillier.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 23:
(1 comment)
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/a3d83e99_09f6e015 :
PS23, Line 93: static char name[5];
...
why is this 5 char? shouldn't this be '10EC5650' normally?
This is ACPI device name which can be 4 chars at max.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 23
Gerrit-Owner: Jianeng Ceng cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Dolan Liu liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Jianeng Ceng cengjianeng@huaqin.corp-partner.google.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 21 Apr 2024 10:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment