Attention is currently required from: Reka Norman, Tim Wawrzynczak, Krishna P Bhat D, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61106 )
Change subject: soc/intel/alderlake: Add GPP_I GPIO group for Alder Lake N SOC
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/61106/comment/a1178408_988b871d
PS10, Line 125: /* GPP S, D, H
: GPP S, I, D, H for Alder Lake N only */
nit:
/* GPP S, D, H for ADL-P/M and GPP S, I, D, H for ADL-N */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71a399c03cb7d098a381bd9439d448e8a620761
Gerrit-Change-Number: 61106
Gerrit-PatchSet: 10
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 06:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment