[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VIO18 - coreboot-gerrit

12 Apr 2023


      Attention is currently required from: Hung-Te Lin, cong yang, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/74341/comment/752c90d3_f5af6c09 
PS4, Line 927: 	case MT6366_VIO18:
Should we assert that `voltage_uv == 1800000`? Please also define a constant marco for `1800000`.
I'd suggest we do the same for `MT6366_VRF12` (in another patch).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 4
Gerrit-Owner: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 14:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment