Attention is currently required from: Cliff Huang, Paul Menzel, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email )
Change subject: mb/intel/mtlrvp: Set USB2-10 as cnvi_wifi bluetooth companion device
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83310/comment/eb0e8b6b_ef96007f?usp... :
PS2, Line 7: Set cnvi_wifi bluetooth companion device
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/83310/comment/2b0e52a2_0631da10?usp... :
PS2, Line 14: return
return*s*?
Done
File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83310/comment/e24aca97_cd4f6d89?usp... :
PS2, Line 406: register "type" = "UPC_TYPE_INTERNAL"
Could be also mentioned in the commit message. Feel free to ignore though.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83310?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61
Gerrit-Change-Number: 83310
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: YH Lin
yueherngl@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 08 Jul 2024 16:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org