the following patch was just integrated into master: commit c2f177737bb2ae1836b3badeb90daf6bdcc2134f Author: Paul Menzel paulepanter@users.sourceforge.net Date: Mon Apr 29 23:05:44 2013 +0200
Lenovo ThinkPad X60: Clean up `romstage.c`
1. Move comment for console init to correct place. 2. Start output with capital letter and add full stop at the end. 3. Add missing »)« at the end of description of GPIO 10. 4. Use tabulators instead of spaces. 5. Indent the code automatically using GNU indent [1] with the `-sc` switch adding stars in front of comment blocks as the good indent manual documents.
$ indent -linux -sc src/mainboard/lenovo/x60/romstage.c
Leave the numbers left aligned as it is more beneficial to be able to run indent without adapting the result afterward.
[1] http://www.coreboot.org/Development_Guidelines#Coding_Style
Change-Id: I2fa018ec28ff19d23d68754b565c13a7d7a57355 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: http://review.coreboot.org/3185 Tested-by: build bot (Jenkins) Reviewed-by: Denis Carikli GNUtoo@no-log.org Reviewed-by: Ronald G. Minnich rminnich@gmail.com
Build-Tested: build bot (Jenkins) at Fri May 3 16:04:36 2013, giving +1 Reviewed-By: Denis Carikli GNUtoo@no-log.org at Sat May 4 21:24:17 2013, giving +1 Reviewed-By: Ronald G. Minnich rminnich@gmail.com at Sat May 4 22:20:04 2013, giving +2 See http://review.coreboot.org/3185 for details.
-gerrit