Change in coreboot[master]: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs

[Malik Hsu (Code Review)]

Malik Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

mb/google/volteer/eldrid: Add option to enable WiFi SAR configs

This change adds a user selectable option to enable all WiFi SAR
configs that apply to volteer

BUG=b:168169690

Change-Id: I6b74cd2b34ebb99cc59d456e28fd7ab2399d71d0
---
M src/mainboard/google/volteer/Kconfig
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/45233/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index dda2f4e..6fb1766 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -45,6 +45,16 @@
    select VBOOT_LID_SWITCH
    select VBOOT_EARLY_EC_SYNC

+config CHROMEOS_WIFI_SAR
+	bool "Enable SAR options for Chrome OS build"
+	depends on CHROMEOS
+	select DSAR_ENABLE
+	select GEO_SAR_ENABLE
+	select SAR_ENABLE
+	select USE_SAR
+	select WIFI_SAR_CBFS
+
+
 config DIMM_SPD_SIZE
    int
    default 512

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45233/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45233/1//COMMIT_MSG@15 
PS1, Line 15: 
You're missing the 'Signed-off-by: ' line, you need to commit with "git commit -s" or add it manually.

[Malik Hsu (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45233

to look at the new patch set (#2).

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

mb/google/volteer/eldrid: Add option to enable WiFi SAR configs

This change adds a user selectable option to enable all WiFi SAR
configs that apply to volteer

BUG=b:168169690

Change-Id: I6b74cd2b34ebb99cc59d456e28fd7ab2399d71d0
Signed-off-by: Malik_Hsu 
---
M src/mainboard/google/volteer/Kconfig
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/45233/2

[Malik Hsu (Code Review)]

Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45233/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45233/1//COMMIT_MSG@15 
PS1, Line 15:
> You're missing the 'Signed-off-by: ' line, you need to commit with "git commit -s" or add it manuall […]

Done, thanks.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 2:

Do you have SAR tables made up for Eldrid yet?

[Malik Hsu (Code Review)]

Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 2:
> Patch Set 2:
>
> Do you have SAR tables made up for Eldrid yet?

Yes

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 2: Code-Review+1

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG@13 
PS2, Line 13: 
Do you verified this patch? If so, please add 'TEST='

[Malik Hsu (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Furquan Shaikh, Zhuohao Lee, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45233

to look at the new patch set (#3).

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

mb/google/volteer/eldrid: Add option to enable WiFi SAR configs

This change adds a user selectable option to enable all WiFi SAR
configs that apply to volteer

BUG=b:168169690
TEST=1. cros-workon-volteer start
          coreboot-private-files-baseboard-volteer
     2. USE="project_eldrid" emerge-volteer chromeos-config
          coreboot-private-files-baseboard-volteer
     3. check wifi_sar-eldrid.hex in
          coreboot-private/3rdparty/blobs/baseboard-volteer

Change-Id: I6b74cd2b34ebb99cc59d456e28fd7ab2399d71d0
Signed-off-by: Malik_Hsu 
---
M src/mainboard/google/volteer/Kconfig
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/45233/3

[Malik Hsu (Code Review)]

Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG@13 
PS2, Line 13:
> Do you verified this patch? If so, please add 'TEST='

Done.

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 3: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 3: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45233/2//COMMIT_MSG@13 
PS2, Line 13:
> Done.

Done

[Malik Hsu (Code Review)]

Malik Hsu has removed Zhuohao Lee from this change.  ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Removed reviewer Zhuohao Lee.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

mb/google/volteer/eldrid: Add option to enable WiFi SAR configs

This change adds a user selectable option to enable all WiFi SAR
configs that apply to volteer

BUG=b:168169690
TEST=1. cros-workon-volteer start
          coreboot-private-files-baseboard-volteer
     2. USE="project_eldrid" emerge-volteer chromeos-config
          coreboot-private-files-baseboard-volteer
     3. check wifi_sar-eldrid.hex in
          coreboot-private/3rdparty/blobs/baseboard-volteer

Change-Id: I6b74cd2b34ebb99cc59d456e28fd7ab2399d71d0
Signed-off-by: Malik_Hsu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45233
Reviewed-by: Caveh Jalali 
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/volteer/Kconfig
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Caveh Jalali: Looks good to me, but someone else must approve
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index dda2f4e..d2880bf 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -45,6 +45,15 @@
    select VBOOT_LID_SWITCH
    select VBOOT_EARLY_EC_SYNC

+config CHROMEOS_WIFI_SAR
+	bool "Enable SAR options for Chrome OS build"
+	depends on CHROMEOS
+	select DSAR_ENABLE
+	select GEO_SAR_ENABLE
+	select SAR_ENABLE
+	select USE_SAR
+	select WIFI_SAR_CBFS
+
 config DIMM_SPD_SIZE
    int
    default 512

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45233 )

Change subject: mb/google/volteer/eldrid: Add option to enable WiFi SAR configs
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19972
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19971
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19970
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19969
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19968
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19976
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19975
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19974
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19973

Please note: This test is under development and might not be accurate at all!