Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Subrata Banik.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/029b91af_7e249504?usp... :
PS1, Line 39: select SOC_INTEL_CRASHLOG
ummm, can you move the below code into JSL SoC Kconfig in that way, it might help you ? […]
I also don't know why we'd want to move it to the SoC vs the mainboard
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jędrzej Ciupis
jciupis@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jędrzej Ciupis
jciupis@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Comment-Date: Sun, 15 Sep 2024 12:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com