Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48750/5/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/5/src/mainboard/clevo/cml-u/v... PS5, Line 69: register "gfx" = "GMA_STATIC_DISPLAYS(0)" : register "gpu_pch_backlight_pwm_hz" = "1000" : register "gpu_pp_cycle_delay_ms" = " 500" : register "gpu_pp_up_delay_ms" = " 200" : register "gpu_pp_down_delay_ms" = " 50" : register "gpu_pp_backlight_on_delay_ms" = " 1" : register "gpu_pp_backlight_off_delay_ms" = " 1" Is it Gerrit acting up, or is the whitespace before the equals signs inconsistent? (mixed tabs and spaces)