Attention is currently required from: Angel Pons, Kyösti Mälkki, Patrick Rudolph, Elyes Haouas.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 )
Change subject: [WIP]aopen/dxplplusu: Support SMM_ASEG and SMM_TSEG
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163755):
https://review.coreboot.org/c/coreboot/+/61517/comment/e02f223e_ce74d1e9
PS5, Line 13:
'occuring' may be misspelled - perhaps 'occurring'?
File src/northbridge/intel/e7505/memmap.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163755):
https://review.coreboot.org/c/coreboot/+/61517/comment/ac2e59bb_9782a277
PS5, Line 40: return 512 *KiB;
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If20a7092117612a1a9e25eb6ac480e105acd57d7
Gerrit-Change-Number: 61517
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 16 Nov 2022 05:15:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment