Change in ...coreboot[master]: mb/google/sarien: add ish firmware_variant field to _DSD

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Jett Rink (Code Review)

2 Mar 2019 2 Mar '19

2:42 a.m.

Jett Rink has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31683

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

mb/google/sarien: add ish firmware_variant field to _DSD

We want to publish "arcada_ish" as the fw variant name for ISH, so the kernel shim loader code can use it to construct the correct path in /lib/firmware/intel for the firmware load process.

BRANCH=none BUG=b:122722008 TEST=Verify that shim loader CLs use new value when constructing firmware path

Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/mainboard/google/sarien/Kconfig M src/mainboard/google/sarien/variants/arcada/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31683/1

diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index a976d36..8919057 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -4,6 +4,7 @@ select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID + select DRIVERS_INTEL_ISH if BOARD_GOOGLE_ARCADA select DRIVERS_SPI_ACPI select DRIVERS_PS2_KEYBOARD select DRIVERS_USB_ACPI diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 244ba7a..154053b 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -195,7 +195,12 @@ device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2 - device pci 13.0 on end # Integrated Sensor Hub + device pci 13.0 on # Integrated Sensor Hub + chip drivers/intel/ish + register "firmware_variant" = ""arcada_ish"" + device generic 0 on end + end + end device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub""

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Lijian Zhao (Code Review)

2 Mar 2 Mar

8:35 a.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 4: Code-Review+2

Lijian Zhao (Code Review)

8:36 a.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31683/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31683/4//COMMIT_MSG@13 PS4, Line 13: BRANCH=none BRANCH is not needed here

rushikesh s kadam (Code Review)

5 Mar 5 Mar

12:24 a.m.

rushikesh s kadam has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: firmware_variant "firmware-name"?

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: arcada_ish The _DSD() should return full filename.

https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...

Paul Menzel (Code Review)

2:43 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31683/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31683/5//COMMIT_MSG@9 PS5, Line 9: ISH Could be spelled out in the commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 5 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Mon, 04 Mar 2019 17:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

6 Mar 6 Mar

7:22 a.m.

Hello Aaron Durbin, build bot (Jenkins), Lijian Zhao, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31683

to look at the new patch set (#6).

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

mb/google/sarien: add ish firmware_variant field to _DSD

We want to publish "arcada_ish" as the fw variant name for ISH, so the kernel shim loader code can use it to construct the correct path in /lib/firmware/intel for the firmware load process.

BRANCH=none BUG=b:122722008 TEST=Verify that shim loader CLs use new value when constructing firmware path

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31683/6

Jett Rink (Code Review)

7:28 a.m.

Hello Aaron Durbin, build bot (Jenkins), Lijian Zhao, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31683

to look at the new patch set (#7).

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

mb/google/sarien: add ish firmware_variant field to _DSD

We want to publish "arcada_ish.bin" as the fw name for Integrated Sensor Hub (ISH) so the kernel shim loader code can use it to construct the correct path in /lib/firmware/intel for the firmware load process.

BUG=b:122722008 TEST=Verify that shim loader CLs use new value when constructing firmware path

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31683/7

Jett Rink (Code Review)

7:29 a.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 7:

(4 comments)

https://review.coreboot.org/#/c/31683/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31683/4//COMMIT_MSG@13 PS4, Line 13: BRANCH=none

...

BRANCH is not needed here

Done

https://review.coreboot.org/#/c/31683/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31683/5//COMMIT_MSG@9 PS5, Line 9: ISH

...

Could be spelled out in the commit message.

Done

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: arcada_ish

...

The _DSD() should return full filename. […]

Done

https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: firmware_variant

...

"firmware-name"?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 7 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Tue, 05 Mar 2019 22:29:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: rushikesh s kadam rushikesh.s.kadam@intel.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Lijian Zhao lijian.zhao@intel.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

12:59 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 7 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Wed, 06 Mar 2019 03:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Mar 7 Mar

5:02 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

mb/google/sarien: add ish firmware_variant field to _DSD

BUG=b:122722008 TEST=Verify that shim loader CLs use new value when constructing firmware path

Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Signed-off-by: Jett Rink jettrink@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/31683 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/sarien/Kconfig M src/mainboard/google/sarien/variants/arcada/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index ce6b810..462ff06 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -4,6 +4,7 @@ select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID + select DRIVERS_INTEL_ISH if BOARD_GOOGLE_ARCADA select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_GOOGLE_WILCO diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 244ba7a..c966e9a 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -195,7 +195,12 @@ device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2 - device pci 13.0 on end # Integrated Sensor Hub + device pci 13.0 on # Integrated Sensor Hub + chip drivers/intel/ish + register "firmware_name" = ""arcada_ish.bin"" + device generic 0 on end + end + end device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub""

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 8 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-MessageType: merged

Kyösti Mälkki (Code Review)

15 Mar 15 Mar

10:44 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... PS8, Line 213: device usb 2.0 on end A bit unrelated, but we should fix devicetree notation.

Those desc, type and group -registers should be defined inside the device usb 2.0 group. The configuration should be per-device, not per-chip properties.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 8 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Fri, 15 Mar 2019 13:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:56 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... PS8, Line 213: device usb 2.0 on end

...

A bit unrelated, but we should fix devicetree notation. […]

I think that is true for all devices and not just restricted to USB. The way coreboot has chip<->device organization seems inverted. e.g. i2c drivers below --> the properties apply to i2c device and not the chip.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 8 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Fri, 15 Mar 2019 13:56:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Jett Rink (Code Review)

16 Mar 16 Mar

12:03 a.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... PS8, Line 213: device usb 2.0 on end

...

I think that is true for all devices and not just restricted to USB. […]

I agree that is seems inverted. It was initially confusing to me.

The way it is now though allows multiple devices on the same chip. Each device would point to the same chip_info structure

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 8 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Fri, 15 Mar 2019 15:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

12:25 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )

Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:

https://review.coreboot.org/#/c/31683/8/src/mainboard/google/sarien/variants... PS8, Line 213: device usb 2.0 on end

...

I agree that is seems inverted. It was initially confusing to me. […]

The keyword 'chip' has confused me many times and causes strange nesting/indenting in these devicetree.cb files, while the generated mb/static.c files are ok. That 'chip' could be an attribute inside the 'device usb 2.0' block on our sconfig syntax.

And yes, this is not limited to USB at all. This is just closely coupled with source tree layout that implies 'one chip.h one info structure'.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6299de82566a3bad8521f8158bb047d5c1ff0cf8 Gerrit-Change-Number: 31683 Gerrit-PatchSet: 8 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-CC: rushikesh s kadam rushikesh.s.kadam@intel.com Gerrit-Comment-Date: Fri, 15 Mar 2019 15:25:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Comment-In-Reply-To: Jett Rink jettrink@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

2032

days inactive

2046

days old

coreboot-gerrit@coreboot.org

13 comments

7 participants

tags (0)

participants (7)

Furquan Shaikh (Code Review)
Jett Rink (Code Review)
Kyösti Mälkki (Code Review)
Lijian Zhao (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
rushikesh s kadam (Code Review)