Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35406 )
Change subject: soc/intel/common/block: Stitch CSE blobs into FW_MAIN_X partitions ......................................................................
Patch Set 64:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35406/62/src/soc/intel/common/block... File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35406/62/src/soc/intel/common/block... PS62, Line 11: add_intel_me_rw
Do you suggest a KConfig CONFIG_RW_REGION_ONLY which allow addition of me_rw.bin blob (basically CSE FW update logic) to coreboot?
Actually, CONFIG_RW_REGION_ONLY is a Kconfig already present in coreboot that allows you to define what components of firmware should land only in RW_A/B and not in RO. So, I was wondering if using CONFIG_RW_REGION_ONLY would get rid of all the changes added to this Makefile. But this is okay for now.
Even though CONFIG_SOC_INTEL_CSE_RW_FILE config enables/disable CSE FW update logic, I feel it's good to have a KConfig to do the same. Thoughts?
Might not be too bad. Saves a CBFS lookup. But we can take that up as follow-up. I think we can go ahead with what we have here for now.
https://review.coreboot.org/c/coreboot/+/35406/64/src/soc/intel/common/block... File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35406/64/src/soc/intel/common/block... PS64, Line 12: sync Why is the sync and sleep added?