Attention is currently required from: Hung-Te Lin. Nina-CM Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49790 )
Change subject: soc/mediatek/mt8192: devapc: Add domain remap setting ......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/49790/comment/269ef9ee_ba98af96 PS1, Line 21: TINYSYS to non-EMI (3-bit to 4-bit) : * 1. SCP from 2 to 2 : * 2. others from XXX to 15
can there be a quick explanation for how these remap is encoded as 0xfffff2ffu? […]
Done
File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/49790/comment/2e46cc31_577a2690 PS3, Line 50: static uintptr_t devapc_base[DEVAPC_AO_MAX] = { : DEVAPC_INFRA_AO_BASE, : DEVAPC_PERI_AO_BASE, : DEVAPC_PERI2_AO_BASE, : DEVAPC_PERI_PAR_AO_BASE, : DEVAPC_FMEM_AO_BASE, : }; : : static void (*master_init[DEVAPC_AO_MAX])(uintptr_t) = { : infra_master_init, : peri_master_init, : NULL, : NULL, : fmem_master_init, : };
do you mind changing this to […]
Done