Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75768?usp=email )
Change subject: soc/intel/cmn/cse: Rename `cse_store_rw_fw_ver` helper fn
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/75768/comment/5a0f20f1_a2670865 :
PS1, Line 1306: /* Store the CSE RW Firmware Version into CBMEM */
: cse_store_rw_fw_version();
This looks more than just renaming a function
as we have moved the code block from line 1312 to 1307 hence, updated the comment section as well to specify this function is to store the CSE RW FW version.
Irrespective of this function being renamed or not, the additional comment being added due to decoupling
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75768?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba85807b7d9e6f067b5b628c6fa062fab5c485e0
Gerrit-Change-Number: 75768
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 07:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment