Attention is currently required from: Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Arthur Heymans has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84316?usp=email )
Change subject: soc/intel/xeon_sp: Remove INCLUDE_PCI_ALL bit for IBL platforms
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/84316/comment/a6e28a85_d5828b6c?usp... :
PS1, Line 271: if (!CONFIG(SOC_INTEL_COMMON_IBL_BASE) && is_dev_on_domain0(iommu)) {
: printk(BIOS_DEBUG, "[Hardware Unit Definition] Flags: 0x%x, PCI Segment Number: 0x%x, "
: "Register Base Address: 0x%x\n",
: DRHD_INCLUDE_PCI_ALL, pcie_seg, reg_base);
: current += acpi_create_dmar_drhd(current, DRHD_INCLUDE_PCI_ALL,
: pcie_seg, reg_base, vtd_probe_bar_size(iommu));
: } else {
: printk(BIOS_DEBUG, "[Hardware Unit Definition] Flags: 0x%x, PCI Segment Number: 0x%x, "
: "Register Base Address: 0x%x\n", 0, pcie_seg, reg_base);
: current += acpi_create_dmar_drhd(current, 0, pcie_seg, reg_base,
: vtd_probe_bar_size(iommu));
: }
can we get rid of the if else statement and change the function input into a variable called flags? That would make it a bit easier to read.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0755143b21633d5fa8fe4a6eb93e4e6ff0301ab5
Gerrit-Change-Number: 84316
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 10:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No