build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37867 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC ......................................................................
Patch Set 3:
(20 comments)
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5250: uint8_t enabled; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5250: uint8_t enabled; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5251: uint8_t role; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5251: uint8_t role; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5252: uint8_t polarity; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5252: uint8_t polarity; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5253: char state[32]; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5253: char state[32]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5254: uint8_t cc_state; /* enum pd_cc_states representing cc state */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5254: uint8_t cc_state; /* enum pd_cc_states representing cc state */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5255: uint8_t dp_mode; /* Current DP pin mode (MODE_DP_PIN_[A-E]) */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5255: uint8_t dp_mode; /* Current DP pin mode (MODE_DP_PIN_[A-E]) */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5256: uint8_t cable_type; /* USBC_CABLE_TYPE_*cable_type */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5256: uint8_t cable_type; /* USBC_CABLE_TYPE_*cable_type */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5257: uint8_t control_flags; /* USB_PD_MUX_*flags */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5257: uint8_t control_flags; /* USB_PD_MUX_*flags */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5258: uint8_t cable_speed; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5258: uint8_t cable_speed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5259: uint8_t cable_gen; /* rounded_support */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37867/3/src/ec/google/chromeec/ec_c... PS3, Line 5259: uint8_t cable_gen; /* rounded_support */ please, no spaces at the start of a line