Attention is currently required from: Felix Singer, Mike Banon, Branden Waldner, Martin Roth, awokd@danwin1210.me, Paul Menzel, Angel Pons, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59677 )
Change subject: Documentation: Add template for deprecation notices
......................................................................
Patch Set 3:
(4 comments)
File Documentation/releases/templates.md:
https://review.coreboot.org/c/coreboot/+/59677/comment/cb6f08c9_403f73b1
PS2, Line 6: down the road (must cover at least 6 months from
: the release that comes with the notice) some part of coreboot
I feel like there is missing something before/after the brackets.
I think it's correct but the sentence is rather convoluted. The side note doesn't help, either. Please check if the new version is easier to understand.
https://review.coreboot.org/c/coreboot/+/59677/comment/705e1345_a49186e6
PS2, Line 10: helps keep
helps *to* keep
Possible, but not this time: https://english.stackexchange.com/questions/3578/what-is-the-correct-way-to-...
https://review.coreboot.org/c/coreboot/+/59677/comment/c62339c1_19baf54c
PS2, Line 11: improving
improve
Done
https://review.coreboot.org/c/coreboot/+/59677/comment/c7c5854a_b7390606
PS2, Line 47: #### Call to action
Add new line here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2cc4f799804c7d56db572823246c487cd19a726
Gerrit-Change-Number: 59677
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: awokd@danwin1210.me
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Branden Waldner
scruffy99@gmail.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Branden Waldner
scruffy99@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: awokd@danwin1210.me
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 22:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment