Attention is currently required from: Jakub Czapiga, Nico Huber.
Nicholas Sudsgaard has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/84088?usp=email )
Change subject: b64_decode-test: Properly terminate strings before comparison
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Is there a reason why we can't add the null terminator in the `b64_decode()` function?
Commit Message:
https://review.coreboot.org/c/coreboot/+/84088/comment/3eed0ace_a96ee869?usp... :
PS1, Line 10: encoded
Do you mean decoded?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1bd2c3ff06bc1d4e5aa21ddd0f1d5802540999d
Gerrit-Change-Number: 84088
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Comment-Date: Mon, 26 Aug 2024 00:58:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No