Change in coreboot[master]: mb/ocp/deltalake: Enable IPMI KCS

[Morgan Jang (Code Review)]

Morgan Jang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41023/1

diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig
index f927174..1a578c5 100644
--- a/src/mainboard/ocp/deltalake/Kconfig
+++ b/src/mainboard/ocp/deltalake/Kconfig
@@ -8,6 +8,11 @@
    select MAINBOARD_USES_FSP2_0
    select SOC_INTEL_COOPERLAKE_SP
    select SUPERIO_ASPEED_AST2400
+	select IPMI_KCS
+
+config IPMI_KCS_REGISTER_SPACING
+	int
+	default 4

config MAINBOARD_DIR
    string
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb
index 27c72af..2044474 100644
--- a/src/mainboard/ocp/deltalake/devicetree.cb
+++ b/src/mainboard/ocp/deltalake/devicetree.cb
@@ -54,6 +54,8 @@
    register "coherency_support" = "0"
    register "ats_support" = "0"

+	register "gen2_dec" = "0x000c0ca1" # IPMI KCS
+
    device cpu_cluster 0 on
      device lapic 0 on end
    end
@@ -86,7 +88,13 @@
    	device pci 1c.4 on end # PCI bridge: Intel Corporation Device a214
    	device pci 1c.5 on end # PCI bridge: Intel Corporation Device a215
    	device pci 1d.0 on end # PCI bridge: Intel Corporation Device a218
-		device pci 1f.0 on end # ISA bridge: Intel Corporation Device a245
+		device pci 1f.0 on
+			chip drivers/ipmi # BMC KCS
+				device pnp ca2.0 on end
+				register "bmc_i2c_address" = "0x20"
+				register "bmc_boot_timeout" = "60"
+			end
+		end # ISA bridge: Intel Corporation Device a245
    	device pci 1f.2 on end # Memory controller: Intel Corporation Device a221
    	device pci 1f.3 on end # Audio device: Intel Corporation Device a270
    	device pci 1f.4 on end # Intel Corporation C620 Series Chipset Family SMBus

[Johnny Lin (Code Review)]

Johnny Lin has uploaded a new patch set (#3) to the change originally created by Morgan Jang. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41023/3

[Johnny Lin (Code Review)]

Johnny Lin has uploaded a new patch set (#5) to the change originally created by Morgan Jang. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41023/5

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

Patch Set 5: Code-Review+2

[Johnny Lin (Code Review)]

Johnny Lin has uploaded a new patch set (#6) to the change originally created by Morgan Jang. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41023/6

[Johnny Lin (Code Review)]

Johnny Lin has uploaded a new patch set (#7) to the change originally created by Morgan Jang. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41023/7

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

Patch Set 8: Code-Review+1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

Patch Set 8: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41023 )

Change subject: mb/ocp/deltalake: Enable IPMI KCS
......................................................................

mb/ocp/deltalake: Enable IPMI KCS

Config the IO port for IPMI KCS and set bmc_boot_timeout for checking BMC self test result.

TEST=Check if the BMC IPMI reponse data is correct or not.

Change-Id: I675060299b486986ebc39d8f714615b3e13de89a
Signed-off-by: Morgan Jang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41023
Reviewed-by: Jonathan Zhang 
Reviewed-by: Patrick Rudolph 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Jonathan Zhang: Looks good to me, but someone else must approve

diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig
index 679115a..d61a3a6 100644
--- a/src/mainboard/ocp/deltalake/Kconfig
+++ b/src/mainboard/ocp/deltalake/Kconfig
@@ -8,6 +8,11 @@
    select MAINBOARD_USES_FSP2_0
    select SOC_INTEL_COOPERLAKE_SP
    select SUPERIO_ASPEED_AST2400
+	select IPMI_KCS
+
+config IPMI_KCS_REGISTER_SPACING
+	int
+	default 4

config MAINBOARD_DIR
    string
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb
index 26912d1..2586b73 100644
--- a/src/mainboard/ocp/deltalake/devicetree.cb
+++ b/src/mainboard/ocp/deltalake/devicetree.cb
@@ -36,6 +36,8 @@
    register "coherency_support" = "0"
    register "ats_support" = "0"

+	register "gen2_dec" = "0x000c0ca1" # IPMI KCS
+
    device cpu_cluster 0 on
      device lapic 0 on end
    end
@@ -70,7 +72,13 @@
    	device pci 1c.4 on end # PCI bridge: Intel Device a214
    	device pci 1c.5 on end # PCI bridge: Intel Device a215
    	device pci 1d.0 on end # PCI bridge: Intel Device a218
-		device pci 1f.0 on end # ISA bridge: Intel Device a245
+		device pci 1f.0 on
+			chip drivers/ipmi # BMC KCS
+				device pnp ca2.0 on end
+				register "bmc_i2c_address" = "0x20"
+				register "bmc_boot_timeout" = "60"
+			end
+		end # ISA bridge: Intel Device a245
    	device pci 1f.1 on end # p2sb
    	device pci 1f.2 on end # Memory controller: Intel Device a221
    	device pci 1f.3 on end # Audio device: Intel Device a270