Julius Werner has posted comments on this change. ( https://review.coreboot.org/22780 )
Change subject: google/scarlet: support INNOLUX P097PFG panel ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c File src/mainboard/google/gru/mainboard.c:
https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c... PS1, Line 567: if (IS_ENABLED(CONFIG_GRU_BASEBOARD_SCARLET)) { Let's not add this until we have other boards that need different panels.
https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c... PS1, Line 568: if (sku_id() == 6) { Let's make this a switch-case statement. I think according to the current plan only SKU pin 0 decides the panel, and the others are reserved for non-panel components (at least for now). So this should be:
switch (sku_id()) { case 0: case 2: case 4: case 6: ...innolux... case 1: case 3: case 5: case 7: ...king... }
(Although Brian just told me that apparently our SKU pins don't read the way we expected them to, so that might still change once we figure out what's going on.)