Attention is currently required from: Wisley Chen.
Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/83291?usp=email
to review the following change.
Change subject: mb/google/nissa/var/domika: Create a domika variant ......................................................................
mb/google/nissa/var/domika: Create a domika variant
This patch creates a new domika variant which is a Twinlake platform. This variant uses Yavilla board mounted with the Twinlake SOC and hence the plan is to reuse the existing nivviks code.
BUG=b:350399367 BRANCH=firmware-nissa-15217.B TEST=build, and boot into OS
Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/83291/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 59b09e0..a95f1f7 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -227,6 +227,15 @@ select SOC_INTEL_RAPTORLAKE select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS
+config BOARD_GOOGLE_DOMIKA + select BOARD_GOOGLE_BASEBOARD_NISSA + select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_INTEL_MIPI_CAMERA + select HAVE_WWAN_POWER_SEQUENCE + select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG + select CHROMEOS_WIFI_SAR if CHROMEOS + select SOC_INTEL_TWINLAKE + config BOARD_GOOGLE_FELWINTER select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -649,6 +658,7 @@ default 0x0 if BOARD_GOOGLE_CRAASKOV default 0x1 if BOARD_GOOGLE_CROTA default 0x1 if BOARD_GOOGLE_DOCHI + default 0x0 if BOARD_GOOGLE_DOMIKA default 0x1 if BOARD_GOOGLE_FELWINTER default 0x1 if BOARD_GOOGLE_GAELIN default 0x1 if BOARD_GOOGLE_GIMBLE @@ -740,6 +750,7 @@ default "Craaskov" if BOARD_GOOGLE_CRAASKOV default "Crota" if BOARD_GOOGLE_CROTA default "Dochi" if BOARD_GOOGLE_DOCHI + default "Domika" if BOARD_GOOGLE_DOMIKA default "Felwinter" if BOARD_GOOGLE_FELWINTER default "Gaelin" if BOARD_GOOGLE_GAELIN default "Gimble" if BOARD_GOOGLE_GIMBLE @@ -805,6 +816,7 @@ default "craaskov" if BOARD_GOOGLE_CRAASKOV default "crota" if BOARD_GOOGLE_CROTA default "dochi" if BOARD_GOOGLE_DOCHI + default "yavilla" if BOARD_GOOGLE_DOMIKA default "felwinter" if BOARD_GOOGLE_FELWINTER default "gaelin" if BOARD_GOOGLE_GAELIN default "gimble" if BOARD_GOOGLE_GIMBLE diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index a929d01..d67eb25 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -41,6 +41,9 @@ config BOARD_GOOGLE_DOCHI bool "-> Dochi"
+config BOARD_GOOGLE_DOMIKA + bool "-> Domika" + config BOARD_GOOGLE_FELWINTER bool "-> Felwinter"