Attention is currently required from: Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )
Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/spi/spi.c:
https://review.coreboot.org/c/coreboot/+/63982/comment/a1aa46e3_8623fe51 PS1, Line 117: spi_fill_ssdt
Hmm don't you want to do this only when the device cannot be enumerated?
In general yes. But on APL the FSPI controller is not marked as hidden across all the boards and therefore the dev->hidden flag is not reliable. The real hidden device, which is the P2SB, is not marked as such either as during coreboot runtime it is visible and will be hidden by coreboot code before passing over to the payload. Since it is hard coded for APL I guess assuming that FSPI is hidden is a valid assumption.