[M] Change in coreboot[master]: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C ...

[CoolStar (Code Review)]

Attention is currently required from: Martin Roth, Matt DeVillier, Nico Huber, Stefan Reinauer.

CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )

Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................

Patch Set 7:

(3 comments)

File src/mainboard/google/link/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/76159/comment/f45b6d7a_31c12272 :
PS7, Line 50: LINK
> Can't find LINK here: https://uefi.org/acpi_id_list […]

I2C bus driver code: https://github.com/coolstar/gmbusi2c

Atmel IDs are used for the touchpad/touch screen devices/drivers, which are separate, and hence would not suffice

https://review.coreboot.org/c/coreboot/+/76159/comment/1347968e_ad001387 :
PS7, Line 62: VGA
> Doesn't really matter, but I find VGA a bit confusing. What does it mean […]

the I2C bus is literally on the VGA DDC pins

https://review.coreboot.org/c/coreboot/+/76159/comment/8417335f_e1e8eb14 :
PS7, Line 82: ISTP
> Where is this used? For the OS, ATML0000 already identifies as touchpad.

code was based off Samus, where that is present