Attention is currently required from: Hung-Te Lin, Rex-BC Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 2: Verified-1
(11 comments)
File src/soc/mediatek/mt8186/devapc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/e23c7602_9024e628 PS2, Line 23: DAPC_INFRA_AO_SYS0_ATTR("INFRA_AO_SLEEP_CONTROLER", 'CONTROLER' may be misspelled - perhaps 'CONTROLLER'?
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/c3ebb7e2_4f11bf97 PS2, Line 66: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/cf614894_5d6c8fce PS2, Line 71: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/493c4778_3a6ac32b PS2, Line 79: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/cde07f87_71949bf6 PS2, Line 93: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/5e42f9e8_6a6c1975 PS2, Line 94: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/c19db11a_6431f264 PS2, Line 95: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/adf1af5a_1c9b0786 PS2, Line 96: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/bcf95a20_0674bc73 PS2, Line 97: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/cf0732f7_bd843d89 PS2, Line 99: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136074): https://review.coreboot.org/c/coreboot/+/60317/comment/c4cfbba0_79f0d45b PS2, Line 123: DEFINE_BIT(SCP_SSPM_SEC,21) space required after that ',' (ctx:VxV)
-
build bot (Jenkins) (Code Review)