Attention is currently required from: Eric Herrmann, Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75764?usp=email )
Change subject: mb/google/rex: Set FVM configuration for MTL-P 28W
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75764/comment/62a79533_a25adb52 :
PS1, Line 60: register "cep_enable[VR_DOMAIN_IA]" = "1"
what is cep enable? […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/75764/comment/663e6e50_63452992 :
PS1, Line 61: register "fast_vmode_i_trip[VR_DOMAIN_IA]" = "372" # 93A
I think these are out of date. The document I have is 91A, 54A, and 27A respectively. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If834c1af8141a19fd2daae653579225b77cfa6c8
Gerrit-Change-Number: 75764
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Herrmann
eherrmann@chromium.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Eric Herrmann
eherrmann@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 20:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Herrmann
eherrmann@chromium.org
Gerrit-MessageType: comment