Attention is currently required from: Arthur Heymans, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69387 )
Change subject: mb/siemens/mc_ehl2: Enable Marvell PHY 88E1512 driver
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69387/comment/a6a93953_09651329
PS9, Line 197: device pnp 0.0 on end # PHY address
PNP is for LPC/ISA devices. Is it meaningful here? There exists a 'generic' device.
Werner introduce mdio_ops in sconfig. I will use this patch as the base for my patch train and then rearrange the device type.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51d817bc720bf787279777f503efdc17dbb1274d
Gerrit-Change-Number: 69387
Gerrit-PatchSet: 9
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 07:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment