Change in coreboot[master]: lib: set up specific purpose memory as LB_MEM_SOFT_RESERVED - coreboot-gerrit

5 Jun 2021


      Attention is currently required from: Lance Zhao, Marc Jones, Nico Huber, Jonathan Zhang, Philipp Deppenwiese, Tim Wawrzynczak, Julius Werner, Angel Pons, Subrata Banik, Patrick Rudolph, Peter Tsung Ho Wu, Ron Minnich.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52585 )
Change subject: lib: set up specific purpose memory as LB_MEM_SOFT_RESERVED
......................................................................
Patch Set 4:
(1 comment)
File src/include/device/resource.h:
https://review.coreboot.org/c/coreboot/+/52585/comment/c18a7657_7da63d02 
PS4, Line 30: #define IORESOURCE_SOFT_RESERVE	0x01000000
Why not 0x0200000 which would be the next unused bit.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie70795bcb8c97e9dd5fb772adc060e1606f9bab0
Gerrit-Change-Number: 52585
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Peter Tsung Ho Wu tsung@amazon.com
Gerrit-Reviewer: Philipp Deppenwiese philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ron Minnich rminnich@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Marc Jones marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: Philipp Deppenwiese philipp.deppenwiese@9elements.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Peter Tsung Ho Wu tsung@amazon.com
Gerrit-Attention: Ron Minnich rminnich@google.com
Gerrit-Comment-Date: Sat, 05 Jun 2021 08:52:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment