Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45323 )
Change subject: ec/system76: undefine PECI gpio in ACPI to prevent build failure
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45323/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45323/2//COMMIT_MSG@9
PS2, Line 9: PECI
That would be better. Such a short macro name can only bring headaches. […]
in an earlier version I prefixed all gpios with GPP_, but some names (mainly vgpio and those loopbk pins) become veeeeeery long then, so I decided to drop that again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60b752b906d95f858195965544d91c0b9cc9ff8a
Gerrit-Change-Number: 45323
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 13 Sep 2020 22:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment