Attention is currently required from: Nico Huber, Matt DeVillier, Angel Pons, Arthur Heymans, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55810 )
Change subject: broadwell boards: Do not set `ddr_refresh_2x` again
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/auron/variants/buddy/spd/spd.c:
https://review.coreboot.org/c/coreboot/+/55810/comment/5d64e447_1a2b1642
PS9, Line 13: pei_data->ddr_refresh_2x = 1;
ddr_refresh_2x is a rowhammer mitigation. We had some complications with updating stuff in the field: I think back then, romstage was part of the RO partition and so there had been workarounds (e.g. boot, set the flag, force a resume cycle to reinit RAM into 2x refresh). Could these assignments be related to that?
If so, I'd rather keep them, but amend with a comment that it's for old-RO/new-RW scenarios to ensure that refresh_2x is _really_ used under all circumstances.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76478689b3aa27c369a0413d9fbde03674d5e528
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 16:12:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment