Attention is currently required from: Felix Singer, Subrata Banik, Tarun Tuli.
Michael Strosche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76830?usp=email )
Change subject: soc/intel/alderlake/chip.h: Use boolean type where applicable ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/76830/comment/bf3df153_0542405e : PS1, Line 343: uint8_t
bool
Correct, will also be changed.
https://review.coreboot.org/c/coreboot/+/76830/comment/f1876681_7b0fbb14 : PS1, Line 463: uint8_t skip_ext_gfx_scan;
That should be bool. […]
skip_ext_gfx_scan could also be removed for alderlake, because it is never used here. Only use (and definition) is for meteorlake.
https://review.coreboot.org/c/coreboot/+/76830/comment/573c2cf8_86d4bcaa : PS1, Line 482: /* : * GSPIn Default Chip Select Mode: : * 0:Hardware Mode, : * 1:Software Mode : */ : bool serial_io_gspi_cs_mode[CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX]; : /* : * GSPIn Default Chip Select State: : * 0: Low, : * 1: High : */ : bool serial_io_gspi_cs_state[CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX];
These could be a bool, but with the current attribute names it would be rather confusing. […]
In devicetree the configuration values are already enum values (PchSerialIoDisabled, PchSerialIoPci). Because of this I also think it should stay with uint8_t here.