Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59689 )
Change subject: soc/intel/common: Rename compose_cse_version() function name ......................................................................
soc/intel/common: Rename compose_cse_version() function name
The patch renames the compare_cse_version() function to cse_compare_partition_version(). It makes the function generic so that it can be used to check version of any CSE component like IOM, NPHY etc.
TEST=Verified coreboot code build for Brya
Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Change-Id: I88a44a3c0ba2ad8a589602a35ea644dab535b287 --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/59689/1
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 281d381..91c8f5c 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -502,7 +502,7 @@ * If ver_cmp_status < 0, coreboot downgrades CSE RW region * If ver_cmp_status > 0, coreboot upgrades CSE RW region */ -static int compare_cse_version(const struct fw_version *a, const struct fw_version *b) +static int cse_compare_partition_version(const struct fw_version *a, const struct fw_version *b) { if (a->major != b->major) return a->major - b->major; @@ -611,7 +611,7 @@
cbfs_unmap(version_str);
- ret = compare_cse_version(&cbfs_rw_version, cse_get_rw_version(cse_bp_info)); + ret = cse_compare_partition_version(&cbfs_rw_version, cse_get_rw_version(cse_bp_info)); if (ret == 0) return CSE_UPDATE_NOT_REQUIRED; else if (ret < 0)