Attention is currently required from: Ravi kumar, Taniya Das, Julius Werner, mturney mturney. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55079 )
Change subject: sc7180: Add target specific GPIO pin definitions ......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15: Hey Ravi, Could you rebase these in smaller sets going forward? Testing this patch train takes the coreboot builders a really significant amount of time and prevents anyone else from getting their patches tested in the meantime.
We address rebasing long patch trains in the gerrit guidelines document: https://doc.coreboot.org/getting_started/gerrit_guidelines.html?highlight=ge...
Run ‘make what-jenkins-does’ locally on patch trains before submitting. This helps verify that the patch train won’t tie up the jenkins builders for no reason if there are failing patches in the train. For running parallel builds, you can specify the number of cores to use by setting the the CPUS environment variable. Example: make what-jenkins-does CPUS=8
Don’t submit patch trains longer than around 20 patches unless you understand how to manage long patch trains. Long patch trains can become difficult to handle and tie up the build servers for long periods of time if not managed well. Rebasing a patch train over and over as you fix earlier patches in the train can hide comments, and make people review the code multiple times to see if anything has changed between revisions. When pushing long patch trains, it is recommended to only push the full patch train once - the initial time, and only to rebase three or four patches at a time.
-
Martin Roth (Code Review)