Attention is currently required from: Tim Crawford, Martin Roth, Jeremy Soller, Paul Menzel, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47822 )
Change subject: mb/system76/gaze15: Add System76 Gazelle 15
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
File src/mainboard/system76/gaze15/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47822/comment/9fb59a91_2e966b77
PS10, Line 7: void bootblock_mainboard_init(void)
You probably want to use `bootblock_mainboard_early_init` instead
File src/mainboard/system76/gaze15/gpio.c:
https://review.coreboot.org/c/coreboot/+/47822/comment/9651fd2b_5d232f78
PS8, Line 98: //
This is taking me a while to do, since I don't know what changes are significant between the vendor […]
No worries.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10667fa26ac7c4b8eb67da11f3e963062bd0db47
Gerrit-Change-Number: 47822
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:47:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment