Change in coreboot[master]: util/board-status: Reject logs with unknown timestamps

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

29 May 2020 29 May '20

1:49 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

util/board-status: Reject logs with unknown timestamps

Check the output of `cbmem -t` for unknown timestamps. If present, ask the user to rebuild `cbmem`.

Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/board_status/board_status.sh 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41857/1

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 2e93fe2..e772238 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -431,6 +431,11 @@

echo "Getting timestamp data" cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" + if [ $(grep -- unknown "${tmpdir}/${results}/coreboot_timestamps.txt") ]; then + echo "Unknown timestamps found in 'coreboot_timestamps.txt'." \ + "Please rebuild the utility 'cbmem'." + exit $EXIT_FAILURE + fi

if [ "$cmos_enabled" -eq 1 ]; then echo "Verifying that nvramtool is available"

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Paul Menzel (Code Review)

29 May 29 May

1:56 p.m.

Paul Menzel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

util/board-status: Reject logs with unknown timestamps

Check the output of `cbmem -t` for unknown timestamps. If present, ask the user to rebuild `cbmem`.

Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41857/2

Angel Pons (Code Review)

11 Jun 11 Jun

7:16 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41857/2/util/board_status/board_sta... File util/board_status/board_status.sh:

https://review.coreboot.org/c/coreboot/+/41857/2/util/board_status/board_sta... PS2, Line 464: utility 'cbmem' I'd say:

'cbmem' utility and try again

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 11 Jun 2020 17:16:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9 Jul 9 Jul

7:44 p.m.

Hello build bot (Jenkins), Angel Pons, Arthur Heymans,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41857

to look at the new patch set (#3).

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

util/board-status: Reject logs with unknown timestamps

Check the output of `cbmem -t` for unknown timestamps. If present, ask the user to rebuild `cbmem`.

Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M 3rdparty/amd_blobs M 3rdparty/vboot M util/board_status/board_status.sh 3 files changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41857/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

7:45 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41857/2/util/board_status/board_sta... File util/board_status/board_status.sh:

https://review.coreboot.org/c/coreboot/+/41857/2/util/board_status/board_sta... PS2, Line 464: utility 'cbmem'

...

I'd say: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Jul 2020 17:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

8:27 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Jul 2020 18:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12 Jul 12 Jul

9:33 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41857/3/3rdparty/amd_blobs File 3rdparty/amd_blobs:

PS3: not intentional, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sun, 12 Jul 2020 19:33:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

13 Jul 13 Jul

9:08 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41857/3/3rdparty/amd_blobs File 3rdparty/amd_blobs:

PS3:

...

not intentional, right?

Thank you for spotting that. No idea, why these are not updated correctly, when I switch branches and rebase.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 13 Jul 2020 07:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:18 a.m.

Hello build bot (Jenkins), Angel Pons, Arthur Heymans,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41857

to look at the new patch set (#4).

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

util/board-status: Reject logs with unknown timestamps

Check the output of `cbmem -t` for unknown timestamps. If present, ask the user to rebuild `cbmem`.

Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41857/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

15 Jul 15 Jul

2:31 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 Jul 2020 12:31:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:31 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41857 )

Change subject: util/board-status: Reject logs with unknown timestamps ......................................................................

util/board-status: Reject logs with unknown timestamps

Check the output of `cbmem -t` for unknown timestamps. If present, ask the user to rebuild `cbmem`.

Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/41857 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index dd3d8f2..31c3e7c 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -459,6 +459,12 @@ exit $EXIT_FAILURE fi

+if [ $(grep -- unknown "${tmpdir}/${results}/coreboot_timestamps.txt") ]; then + echo "Unknown timestamps found in 'coreboot_timestamps.txt'." \ + "Please rebuild the 'cbmem' utility and try again." + exit $EXIT_FAILURE +fi + # # Finish up. #

-- To view, visit https://review.coreboot.org/c/coreboot/+/41857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief7aa1a698f10d9721964ad1bee057fcd9f4aa40 Gerrit-Change-Number: 41857 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1381

days inactive

1428

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)