Attention is currently required from: Máté Kukri, Paul Menzel, Varshit Pandya.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS7:
Lookiing at the jenkins log this doesnt actually build: […]
It's because `chassis_type` is `uint8_t`. I suggested adding a `CHASSIS_TYPE_UNKNOWN` define for clarity.
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/179d9053_e0442567 :
PS7, Line 290: -1
Put this somewhere
```
#define CHASSIS_TYPE_UNKNOWN 0xff
```
And use it here
https://review.coreboot.org/c/coreboot/+/81529/comment/a84f6c34_6fcc16d3 :
PS7, Line 380: -1
`CHASSIS_TYPE_UNKNOWN`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 7
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 19 Apr 2024 13:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Gerrit-MessageType: comment