Attention is currently required from: Tarun Tuli, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71573 )
Change subject: security/intel/txt: Create Intel TXT lib with helper functions
......................................................................
Patch Set 2:
(3 comments)
File src/security/intel/txt/romstage.c:
https://review.coreboot.org/c/coreboot/+/71573/comment/0fb9610d_de2d95e0
PS1, Line 7: #include <cpu/x86/msr.h>
Is this required? Can you please check?
Ack
https://review.coreboot.org/c/coreboot/+/71573/comment/bfc8093b_60af12af
PS1, Line 10: #include <timer.h>
This is not required.
Ack
https://review.coreboot.org/c/coreboot/+/71573/comment/706152a0_1fbecbbb
PS1, Line 13: #include <security/tpm/tis.h>
Is this required?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff5b4e705e18cbaf181b4c71bfed368c3ed047ed
Gerrit-Change-Number: 71573
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 06 Jan 2023 10:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment