Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Tarun Tuli, Nico Huber, Michał Żygowski, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70276 )
Change subject: drivers/intel/gma: Hook up libgfxinit in romstage
......................................................................
Patch Set 23:
(1 comment)
File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/70276/comment/98122d87_0a602686
PS23, Line 181: if (CONFIG(HWBASE_STATIC_MMIO)) {
Not really as the GOP driver uses its own BAR address anyway which is way more into the middle the 2GB memory hole.
[INFO]:[InitializeGfxMmioBase()]:[GfxMmio Base address: 0xAF000000]
Is this even when we are overriding GtMmAdd UPD with 0xfa00_0000. if yes, then this is wrong. FSP/GFX PEIM should reuse the IGD base and avoid overriding.
0xAF00_0000 is default DSC value for GtMmAdd UPD unless overridden by bootloader.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c2101de10dc5df54fe873e43bbe0f1c4dccff44
Gerrit-Change-Number: 70276
Gerrit-PatchSet: 23
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 06 Jan 2023 17:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment