Attention is currently required from: Bora Guvendik, Selma Bensaid, Hsuan-ting Chen, Paul Menzel, Tim Wawrzynczak, Bernardo Perez Priego.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/intel/adlrvp: Add hook function to return EC in RW status
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58099/comment/395a1a50_8d290456
PS7, Line 9: EC_IN_RW signal from EC GPIO is connected to GPIO E7
: of SOC. The function reads this GPIO to check if EC is in
: RW (un trusted) or RO (trusted)
Ack
i updated the commit message to text as suggested. But the formatting on the Gerrit seems to not preserve that. When i do Git log on my host i see it being as expected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7
Gerrit-Change-Number: 58099
Gerrit-PatchSet: 9
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 17:11:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment