Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: Update ACPICA to 20191018 and build more utilities ......................................................................
Update ACPICA to 20191018 and build more utilities
Update to ACPICA 20191018 which contains significant improvements in the ACPICA tools.
Build the following utilities on Linux for easier debugging of ACPI issues * acpibin * acpidump * acpiexec * acpihelp * acpinames * acpisrc * acpixtract
Change-Id: I84476da8f9a5ba4860ba4ad0220ec3efb229cc03 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20191018_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum 4 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/36337/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6c378ac..5c9dd77 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.32 GDB_VERSION=8.3 -IASL_VERSION=20190703 +IASL_VERSION=20191018 PYTHON_VERSION=3.7.4 EXPAT_VERSION=2.2.7 # CLANG version number @@ -861,9 +861,15 @@ test "$UNAME" = "Cygwin" && HOST="_CYGWIN" HOST="$HOST" CFLAGS="$CFLAGS" \ OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='"coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE"' " \ - $MAKE CC="$(hostcc host)" iasl || touch "$RDIR/.failed" + $MAKE $JOBS CC="$(hostcc host)" iasl || touch "$RDIR/.failed" rm -f "$DESTDIR$TARGETDIR/bin/iasl" || touch "$RDIR/.failed" cp bin/iasl "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + if [ "$UNAME" = "Linux" ]; then + $MAKE $JOBS CC="$(hostcc host)" acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract + rm -f "$DESTDIR$TARGETDIR/bin/{acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract}" || touch "$RDIR/.failed" + cp bin/{acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + fi + }
build_LLVM() { diff --git a/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch b/util/crossgcc/patches/acpica-unix2-20191018_iasl.patch similarity index 73% rename from util/crossgcc/patches/acpica-unix2-20190703_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20191018_iasl.patch index 0f60974..b958dc3 100644 --- a/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20191018_iasl.patch @@ -1,6 +1,6 @@ -diff -Naur acpica-unix2-20190703_/source/compiler/asloptions.c acpica-unix2-20190703/source/compiler/asloptions.c > acpica-unix2-20190703_iasl.patch ---- acpica-unix2-20190703_/source/compiler/asloptions.c -+++ acpica-unix2-20190703/source/compiler/asloptions.c +diff -Naur acpica-unix2-20191018_/source/compiler/asloptions.c acpica-unix2-20191018/source/compiler/asloptions.c > acpica-unix2-20191018_iasl.patch +--- acpica-unix2-20191018_/source/compiler/asloptions.c ++++ acpica-unix2-20191018/source/compiler/asloptions.c @@ -126,6 +126,7 @@ if (Gbl_DoSignon) { diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum deleted file mode 100644 index 9a89796..0000000 --- a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum new file mode 100644 index 0000000..3df9d27 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum @@ -0,0 +1 @@ +792e2ec4dcd78646de8405578d28f7437aacf811 tarballs/acpica-unix2-20191018.tar.gz
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: Update ACPICA to 20191018 and build more utilities ......................................................................
Patch Set 1:
this will fail as 'Processor()' Keyword is deprecated. we need to use 'Device()'. also, there is some wrong _ADR objects ...
please see https://review.coreboot.org/c/coreboot/+/34907
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: Update ACPICA to 20191018 and build more utilities ......................................................................
Patch Set 1:
Patch Set 1:
this will fail as 'Processor()' Keyword is deprecated. we need to use 'Device()'. also, there is some wrong _ADR objects ...
maybe rebase on https://review.coreboot.org/c/coreboot/+/36318/1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: Update ACPICA to 20191018 and build more utilities ......................................................................
Patch Set 2:
New versions of ACPICA are failing due to this sort of error which will need to be fixed across the codebase before we can upgrade: dsdt.asl 1473: Device (ECMM) { Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
dsdt.asl 1491: Device (ECUI) { Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
dsdt.asl 1531: Device (PS2K) Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: Update ACPICA to 20191018 and build more utilities ......................................................................
Patch Set 2:
Patch Set 2:
New versions of ACPICA are failing due to this sort of error which will need to be fixed across the codebase before we can upgrade: dsdt.asl 1473: Device (ECMM) { Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
dsdt.asl 1491: Device (ECUI) { Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
dsdt.asl 1531: Device (PS2K) Warning 3073 - ^ Multiple types (Device object requires either a _HID or _ADR, but not both)
those are already fixed. (https://review.coreboot.org/c/coreboot/+/36260) maybe there some remaining wrong _ADR ...
Hello HAOUAS Elyes, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36337
to look at the new patch set (#6).
Change subject: buildgcc: ACPICA: build more utilities and in parallel ......................................................................
buildgcc: ACPICA: build more utilities and in parallel
- honor $JOBS in build_IASL
- Build the following utilities in addition to iasl for easier debugging of ACPI issues:
* acpibin * acpidump * acpiexec * acpihelp * acpinames * acpisrc * acpixtract
Change-Id: I84476da8f9a5ba4860ba4ad0220ec3efb229cc03 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/36337/6
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: buildgcc: ACPICA: build more utilities and in parallel ......................................................................
Patch Set 6:
Elyes, I think your patch to update IASL was fine and sorry for not seeing this earlier. I removed those parts from this patch and only concentrate on building the additional utilities as well as building in parallel now.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: buildgcc: ACPICA: build more utilities and in parallel ......................................................................
Patch Set 6: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36337 )
Change subject: buildgcc: ACPICA: build more utilities and in parallel ......................................................................
buildgcc: ACPICA: build more utilities and in parallel
- honor $JOBS in build_IASL
- Build the following utilities in addition to iasl for easier debugging of ACPI issues:
* acpibin * acpidump * acpiexec * acpihelp * acpinames * acpisrc * acpixtract
Change-Id: I84476da8f9a5ba4860ba4ad0220ec3efb229cc03 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36337 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6c378ac..b75b90a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -861,9 +861,9 @@ test "$UNAME" = "Cygwin" && HOST="_CYGWIN" HOST="$HOST" CFLAGS="$CFLAGS" \ OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='"coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE"' " \ - $MAKE CC="$(hostcc host)" iasl || touch "$RDIR/.failed" - rm -f "$DESTDIR$TARGETDIR/bin/iasl" || touch "$RDIR/.failed" - cp bin/iasl "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract + rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract}" || touch "$RDIR/.failed" + cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" }
build_LLVM() {
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Stefan Reinauer (Code Review)