Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
mb/supermicro/x11-lga1151-series: Disable i8042 support
Even though the vendor firmware enables the i8042 I/O port, it doesn't feed valid data to those, but instead uses USB HID devices.
Disable the KBC port in SuperI/O and report no KCS port using FADT.
Fixes: * Fixes error message in Linux that i8042 keyboard couldn't be enabled.
Tested on Supermicro X11SSH-TF: The virtual remote managment console still works.
Change-Id: I1cdf648aa5bf1d0ec48520fa1e45bdaf043cb45d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb 2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/36078/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 541b23d..069e65a 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -12,6 +12,7 @@ select SUPERIO_ASPEED_AST2400 select GENERATE_SMBIOS_TABLES select IPMI_KCS + select NO_FADT_8042
if BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES
diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb index 09aa8b5..d08cc36 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb @@ -78,12 +78,7 @@ io 0x66 = 0xa30 irq 0x70 = 0xb end - device pnp 2e.5 on # Keyboard - io 0x60 = 0x60 - io 0x62 = 0x64 - irq 0x70 = 1 - irq 0x72 = 0xc - end + device pnp 2e.5 off end # KBC device pnp 2e.7 on end # GPIO device pnp 2e.b on # SUART3 io 0x60 = 0x3e8
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36078/1//COMMIT_MSG@17 PS1, Line 17: Tested on Supermicro X11SSH-TF: needs testing on x11ssm, too!
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36078/1//COMMIT_MSG@17 PS1, Line 17: Tested on Supermicro X11SSH-TF:
needs testing on x11ssm, too!
ok, looks good. I change that in x11ssm, too
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 12: register "gen2_dec" = "0x000c0ca1" # IPMI KCS can't this be removed then?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 81: KBC KCS
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 81: tab
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 12: register "gen2_dec" = "0x000c0ca1" # IPMI KCS
can't this be removed then?
nope. my fault.
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 81: KBC
KCS
same...
Hello Michael Niewöhner, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36078
to look at the new patch set (#2).
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
mb/supermicro/x11-lga1151-series: Disable i8042 support
Even though the vendor firmware enables the i8042 I/O port, it doesn't feed valid data to those, but instead uses USB HID devices.
Disable the KBC port in SuperI/O and report no KCS port using FADT.
Fixes: * Fixes error message in Linux that i8042 keyboard couldn't be enabled.
Tested on Supermicro X11SSH-TF: The virtual remote managment console still works.
Change-Id: I1cdf648aa5bf1d0ec48520fa1e45bdaf043cb45d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb 2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/36078/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36078/1/src/mainboard/supermicro/x1... PS1, Line 81:
tab
Done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11-lga1151-series: Disable i8042 support ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36078/2//COMMIT_MSG@7 PS2, Line 7: mb/supermicro/x11-lga1151-series you only removed that in x11ssh-tf
Hello Michael Niewöhner, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36078
to look at the new patch set (#3).
Change subject: mb/supermicro/x11ssh-tf: Disable i8042 support ......................................................................
mb/supermicro/x11ssh-tf: Disable i8042 support
Even though the vendor firmware enables the i8042 I/O port, it doesn't feed valid data to those, but instead uses USB HID devices.
Disable the KBC port in SuperI/O and report no KCS port using FADT.
Fixes: * Fixes error message in Linux that i8042 keyboard couldn't be enabled.
Tested on Supermicro X11SSH-TF: The virtual remote managment console still works.
Change-Id: I1cdf648aa5bf1d0ec48520fa1e45bdaf043cb45d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb 2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/36078/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11ssh-tf: Disable i8042 support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36078/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36078/2//COMMIT_MSG@7 PS2, Line 7: mb/supermicro/x11-lga1151-series
you only removed that in x11ssh-tf
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11ssh-tf: Disable i8042 support ......................................................................
Patch Set 3: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11ssh-tf: Disable i8042 support ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36078 )
Change subject: mb/supermicro/x11ssh-tf: Disable i8042 support ......................................................................
mb/supermicro/x11ssh-tf: Disable i8042 support
Even though the vendor firmware enables the i8042 I/O port, it doesn't feed valid data to those, but instead uses USB HID devices.
Disable the KBC port in SuperI/O and report no KCS port using FADT.
Fixes: * Fixes error message in Linux that i8042 keyboard couldn't be enabled.
Tested on Supermicro X11SSH-TF: The virtual remote managment console still works.
Change-Id: I1cdf648aa5bf1d0ec48520fa1e45bdaf043cb45d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36078 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb 2 files changed, 2 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index a3ed8af..ea0214a 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -14,6 +14,7 @@ select IPMI_KCS select MAINBOARD_NO_FSP_GOP select SUPERIO_ASPEED_HAS_UART_DELAY_WORKAROUND + select NO_FADT_8042
if BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES
diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb index 3e587dc..aace4f7 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb @@ -114,12 +114,7 @@ io 0x66 = 0xa30 irq 0x70 = 0xb end - device pnp 2e.5 on # Keyboard - io 0x60 = 0x60 - io 0x62 = 0x64 - irq 0x70 = 1 - irq 0x72 = 0xc - end + device pnp 2e.5 off end # KBC device pnp 2e.7 on end # GPIO device pnp 2e.b on # SUART3 io 0x60 = 0x3e8