Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49276 )
Change subject: i82801jx boards: Do not initialize unused `cmap` ......................................................................
i82801jx boards: Do not initialize unused `cmap`
Nothing uses the value of this field, so don't initialize it.
Change-Id: Ic36f7d68f066719beb5f59bce2ada9671ce52072 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p5qc/acpi_tables.c M src/mainboard/asus/p5ql-em/acpi_tables.c M src/mainboard/intel/dg43gt/acpi_tables.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/49276/1
diff --git a/src/mainboard/asus/p5qc/acpi_tables.c b/src/mainboard/asus/p5qc/acpi_tables.c index 0d0b24c..c9e4a5e 100644 --- a/src/mainboard/asus/p5qc/acpi_tables.c +++ b/src/mainboard/asus/p5qc/acpi_tables.c @@ -9,5 +9,4 @@ gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */ gnvs->apic = 1; /* Enable APIC */ gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->cmap = 0x01; /* Enable COM 1 port */ } diff --git a/src/mainboard/asus/p5ql-em/acpi_tables.c b/src/mainboard/asus/p5ql-em/acpi_tables.c index e678bab..37af4b5 100644 --- a/src/mainboard/asus/p5ql-em/acpi_tables.c +++ b/src/mainboard/asus/p5ql-em/acpi_tables.c @@ -10,7 +10,6 @@ gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */ gnvs->apic = 1; /* Enable APIC */ gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->cmap = 0x01; /* Enable COM 1 port */ }
/* TODO: Could work... */ diff --git a/src/mainboard/intel/dg43gt/acpi_tables.c b/src/mainboard/intel/dg43gt/acpi_tables.c index 0d0b24c..c9e4a5e 100644 --- a/src/mainboard/intel/dg43gt/acpi_tables.c +++ b/src/mainboard/intel/dg43gt/acpi_tables.c @@ -9,5 +9,4 @@ gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */ gnvs->apic = 1; /* Enable APIC */ gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->cmap = 0x01; /* Enable COM 1 port */ }