Attention is currently required from: Martin Roth, Mariusz Szafrański, Michal Motyl.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/2d220daa_f0a823fa
PS1, Line 1222: DEVTREE_CONST
Keep `const` here. See CB:49242 for the reasoning
https://review.coreboot.org/c/coreboot/+/51180/comment/097f3249_848a8e24
PS1, Line 1224: DEVTREE_CONST
Keep `const` here too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 1
Gerrit-Owner: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 14:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment