Attention is currently required from: Sean Rhodes, Nico Huber, Martin Roth, Andrey Petrov, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61872 )
Change subject: soc/apollolake: Create components required for IFWI stitching
......................................................................
Patch Set 14:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61872/comment/47112120_c217eba7
PS14, Line 1321: $(objcbfs)/ibbm.rom:
: # Size is calculate as:
: # IBBP-Sub-Partition - IBBL - Manifest - BPM.met - Padding
: python -c "import struct; fp = open ('$@', 'wb'); \
: fp.write (b'\xFF' * \
: $(shell echo $$((32768 - \
: $(shell stat -Lc %s $(objcbfs)/ibbl.rom) \
: - 748 - 180 - 3168)))); fp.close();"
: printf "\nBuilt $@ (0x%x)\n" `stat -c "%s" $@`
Does this need a dependency? Also inline python inside makefiles is a bad idea.
"dd if=/dev/zero bs=1 count=#filesize | tr "\000" "\377" > foo" could achieve the same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a64e602b8e0d53e1a51b2fbce583c40dfb68c79
Gerrit-Change-Number: 61872
Gerrit-PatchSet: 14
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Mar 2022 13:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment