Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Meera Ravindranath, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60776 )
Change subject: soc/intel/common/gpio: Skip GPP pad lock config if config is not set
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
yes
@Eric, my analysis with #ifdef/#endif, the code size reduction is not very significant compare to how much of #ifdef/#endif we might need to guard like `sideband_msg_err`. Also, long back Aaron told me once to avoid guarding functions if its not getting executed then compiler would optimise it.
WDYT? just if clause is enough?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I392dc2007dba8169e480f82b58b7f0a1578bb09f
Gerrit-Change-Number: 60776
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 19:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment